-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add containerPort declaration for webhook in helm chart #1961
fix: add containerPort declaration for webhook in helm chart #1961
Conversation
Signed-off-by: Zev Isert <dev@zevisert.ca>
Signed-off-by: Zev Isert <dev@zevisert.ca>
Signed-off-by: Zev Isert <dev@zevisert.ca>
@zevisert Eek I broke the CLA by being attached to that commit. Will sign in a second |
Thanks, I'm not sure if anyone knows yet what will happen with the CLA now that Google has donated this project to kubeflow; for now it's part of the CI that came with the donation and everyone is still signing it. I can rebase you off that suggestion and use my name if you'd prefer not to sign the CLA at this time. |
Hi Folks, sorry for the confusions around Google CLA. cc @kubeflow/kubeflow-steering-committee |
Signed-off-by: Zev Isert <dev@zevisert.ca>
30ac0eb
to
88c767e
Compare
Signed-off-by: Zev Isert <dev@zevisert.ca>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuchaoran2011, zevisert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@yuchaoran2011 could you please drop tag |
Yeah I noticed that. I don't have the admin permissions and hence am unable to delete an existing tag. That said, bumping up the chart version without changing the appVersion is common. What would that prevent the chart from being published? |
Is that something I caused here? I had a merge conflict with master over the chart version; I resolved it by keeping the appVersion from master ( |
@zevisert just wanted to retrigger a build and put a tag here, cause it's the latest merged commit |
…w#1961) * fix: add containerPort declaration for webhook in helm chart Signed-off-by: Zev Isert <dev@zevisert.ca> * docs: update helm chart readme Signed-off-by: Zev Isert <dev@zevisert.ca> * fix: copied helm value should be for webhook Signed-off-by: Zev Isert <dev@zevisert.ca> * build: bump helm chart to 1.2.3 Signed-off-by: Zev Isert <dev@zevisert.ca> * style: undo unrelated editor autoformatting Signed-off-by: Zev Isert <dev@zevisert.ca> --------- Signed-off-by: Zev Isert <dev@zevisert.ca> Co-authored-by: Mason Legere <masonlegere@gmail.com> Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
…w#1961) * fix: add containerPort declaration for webhook in helm chart Signed-off-by: Zev Isert <dev@zevisert.ca> * docs: update helm chart readme Signed-off-by: Zev Isert <dev@zevisert.ca> * fix: copied helm value should be for webhook Signed-off-by: Zev Isert <dev@zevisert.ca> * build: bump helm chart to 1.2.3 Signed-off-by: Zev Isert <dev@zevisert.ca> * style: undo unrelated editor autoformatting Signed-off-by: Zev Isert <dev@zevisert.ca> --------- Signed-off-by: Zev Isert <dev@zevisert.ca> Co-authored-by: Mason Legere <masonlegere@gmail.com>
…w#1961) * fix: add containerPort declaration for webhook in helm chart Signed-off-by: Zev Isert <dev@zevisert.ca> * docs: update helm chart readme Signed-off-by: Zev Isert <dev@zevisert.ca> * fix: copied helm value should be for webhook Signed-off-by: Zev Isert <dev@zevisert.ca> * build: bump helm chart to 1.2.3 Signed-off-by: Zev Isert <dev@zevisert.ca> * style: undo unrelated editor autoformatting Signed-off-by: Zev Isert <dev@zevisert.ca> --------- Signed-off-by: Zev Isert <dev@zevisert.ca> Co-authored-by: Mason Legere <masonlegere@gmail.com>
Adds a missing port declaration for the container port serving the webhook to the helm chart. Bumps the chart version for this fix.
Notice that this port is correctly declared in the kustomize patches, it's just the helm chart that didn't expose this.
Here's the port being declared for the kustomize manifests that enable the webhook:
spark-operator/manifest/spark-operator-with-webhook.yaml
Lines 51 to 52 in 252eddd
But here, the helm chart only creates a port for metrics, with no condition to add a port when
.Values.webhook.enable
is truespark-operator/charts/spark-operator-chart/templates/deployment.yaml
Lines 49 to 53 in 252eddd
Closes: #1962