Add some helm chart unit tests and fix spark service account render failure when extra annotations are specified #1967
Conversation
ChenYi015
commented
Apr 12, 2024
•
ChenYi015
commented
- Add some helm chart unit tests
- Close helm chart failed to render spark service account when extra annotations are specified #1966
- Update developer guide about how to setup git pre-commit hooks and developing with helm chart
|
@ChenYi015, could you provide further details on the execution process of these unit tests? Also, could you verify whether you've conducted tests on these modifications using the Helm chart? |
Detailed information about how to run helm chart unit tests can be found here helm-unittest/helm-unittest. First, you need to install helm unit test plugin: helm plugin install https://github.com/helm-unittest/helm-unittest.gitThen, run helm chart unitt tests as follows: $ helm unittest charts/spark-operator-chart --strict
### Chart [ spark-operator ] charts/spark-operator-chart
PASS Test spark operator deployment charts/spark-operator-chart/tests/deployment_test.yaml
PASS Test spark operator rbac charts/spark-operator-chart/tests/rbac_test.yaml
PASS Test spark operator service account charts/spark-operator-chart/tests/serviceaccount_test.yaml
PASS Test spark rbac charts/spark-operator-chart/tests/spark-rbac_test.yaml
PASS Test spark service account charts/spark-operator-chart/tests/spark-serviceaccount_test.yaml
PASS Test spark operator webhook service charts/spark-operator-chart/tests/webhook-service_test.yaml
Charts: 1 passed, 1 total
Test Suites: 6 passed, 6 total
Tests: 46 passed, 46 total
Snapshot: 0 passed, 0 total
Time: 150.450791msIt will search for test files under |
|
I have conducted tests on the modifications with my own k8s cluster, and it works as expected. |
|
Thanks @ChenYi015 ! It would be nice to add this to our contributors.md doc |
Signed-off-by: Yi Chen <github@chenyicn.net>
…e specified Signed-off-by: Yi Chen <github@chenyicn.net>
ChenYi015
force-pushed
the
chart-unit-test
branch
2 times, most recently
from
5866e91
to
387e08d
Compare
|
@vara-bonthu I have updated the developer guide about how to setup git pre-commit hooks and developing with helm chart. |
docs/developer-guide.md
Outdated
| @@ -72,3 +95,82 @@ make build-api-docs | |||
| ``` | |||
|
|
|||
| Running the above command will update the file `docs/api-docs.md`. | |||
|
|
|||
| ## Develope with the Helm Chart | |||
There was a problem hiding this comment.
nit: spelling "Develop"
Signed-off-by: Yi Chen <github@chenyicn.net>
Signed-off-by: Yi Chen <github@chenyicn.net>
ChenYi015
force-pushed
the
chart-unit-test
branch
from
17921c9
to
f361df4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015, vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ailure when extra annotations are specified (kubeflow#1967) * Add helm unit tests Signed-off-by: Yi Chen <github@chenyicn.net> * Fix: failed to render spark service account when extra annotations are specified Signed-off-by: Yi Chen <github@chenyicn.net> * Update developer guide Signed-off-by: Yi Chen <github@chenyicn.net> * Bump helm chart version Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net>
…ailure when extra annotations are specified (kubeflow#1967) * Add helm unit tests Signed-off-by: Yi Chen <github@chenyicn.net> * Fix: failed to render spark service account when extra annotations are specified Signed-off-by: Yi Chen <github@chenyicn.net> * Update developer guide Signed-off-by: Yi Chen <github@chenyicn.net> * Bump helm chart version Signed-off-by: Yi Chen <github@chenyicn.net> --------- Signed-off-by: Yi Chen <github@chenyicn.net> Signed-off-by: Peter McClonski <mcclonski_peter@bah.com>
