Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spark Job Namespace docs #2000

Merged

Conversation

matthewrossi
Copy link
Contributor

Purpose of this PR

In #1955 the use of sparkJobNamespace was replaced with sparkJobNamespaces. However the README.md and the Quick Start Guide still show the use of the old Helm value.

Proposed changes:

  • Update docs with the new Helm value

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Additional Notes

  • To the best of my knowledge there are two ways to set a list value of a Helm Chart: --set "sparkJobNamespaces={default}" and --set sparkJobNamespaces[0]=default (for personal preference I went with the first one)
  • The About the Spark Job Namespace section in the quick start guide was referencing quite heavily the old default value and how the empty string was enabling the deployment of spark applications on all namespaces. From the test I did with Helm chart v1.2.7 it seems to me that the empty list enables the execution of spark applications only in the spark-operator namespace. Based on this information I updated the doc describing this behavior, I may be wrong here, so please correct me if I am missing something

Signed-off-by: Matthew Rossi <mattw.rossi@gmail.com>
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matthewrossi, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a1efb79 into kubeflow:master May 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants