Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples #2010

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

peter-mcclonski
Copy link
Contributor

馃洃 Important:

Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!

For guidelines on how to contribute, please review the CONTRIBUTING.md document.

Purpose of this PR

Updates examples to be runnable out of the box with the latest pre-release version.

Proposed changes:

  • Fixes the default value of sparkJobNamespaces to [""] rather than [], bringing the actual behavior in line with that documented in the user guide.
  • Updates the service account in the example SparkApplications to reflect the default created service account name, allowing them to run out of the box.
  • Updates the spark worker image used in the example SparkApplications to the official Apache 3.5.0 image, as the prior image was unreachable.

Change Category

Indicate the type of change by marking the applicable boxes:

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

In preparation for the first release, we should ensure that all new-user documentation and resources are usable and accessible.

Checklist

Before submitting your PR, please review the following:

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Resolves #2009 , #2008

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @peter-mcclonski 馃憤馃徏

@peter-mcclonski peter-mcclonski force-pushed the fix-examples branch 4 times, most recently from b8f6192 to 5b9e06e Compare May 3, 2024 14:59
@vara-bonthu
Copy link
Contributor

@peter-mcclonski Please sign your commits. Check DCO check

@peter-mcclonski
Copy link
Contributor Author

@peter-mcclonski Please sign your commits. Check DCO check

Yup, working it right now. Had some silliness with Windows vs WSL

@peter-mcclonski peter-mcclonski force-pushed the fix-examples branch 2 times, most recently from c31d70a to 082f004 Compare May 3, 2024 15:18
Signed-off-by: Peter Jablonski <mcclonski.peter@gmail.com>
@peter-mcclonski
Copy link
Contributor Author

@peter-mcclonski Please sign your commits. Check DCO check

Should be all set for you now.

Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: peter-mcclonski, vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] spark-operator-spark serviceaccount lacks necessary permissions
2 participants