New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples #2010
Fix examples #2010
Conversation
9e489d0
to
862503a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @peter-mcclonski 馃憤馃徏
b8f6192
to
5b9e06e
Compare
@peter-mcclonski Please sign your commits. Check DCO check |
5b9e06e
to
b23951e
Compare
Yup, working it right now. Had some silliness with Windows vs WSL |
c31d70a
to
082f004
Compare
Signed-off-by: Peter Jablonski <mcclonski.peter@gmail.com>
082f004
to
eac385f
Compare
Should be all set for you now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: peter-mcclonski, vara-bonthu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
馃洃 Important:
Please open an issue to discuss significant work before you start. We appreciate your contributions and don't want your efforts to go to waste!
For guidelines on how to contribute, please review the CONTRIBUTING.md document.
Purpose of this PR
Updates examples to be runnable out of the box with the latest pre-release version.
Proposed changes:
sparkJobNamespaces
to[""]
rather than[]
, bringing the actual behavior in line with that documented in the user guide.Change Category
Indicate the type of change by marking the applicable boxes:
Rationale
In preparation for the first release, we should ensure that all new-user documentation and resources are usable and accessible.
Checklist
Before submitting your PR, please review the following:
Additional Notes
Resolves #2009 , #2008