Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added DNS config option for the driver and executor pods #519

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Added DNS config option for the driver and executor pods #519

merged 2 commits into from
Jun 14, 2019

Conversation

jlpedrosa
Copy link
Contributor

This PRs adds the option to specify DNSConfig as defined in k8s api for the Driver and the Executor pods.

It adds the objects in the api and modifies the weebhook

liyinan926
liyinan926 reviewed Jun 13, 2019
View reviewed changes
Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The only comment is can we add a section to the user guide for this?

@jlpedrosa
Copy link
Contributor Author

Hi @liyinan926
Done, let me know if there would be anything else.

@liyinan926 liyinan926 merged commit 7f1de86 into kubeflow:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyinan926 liyinan926 liyinan926 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlpedrosa @liyinan926