Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic merges with tide aren't working #52

Closed
jlewi opened this issue Mar 2, 2018 · 5 comments
Closed

Automatic merges with tide aren't working #52

jlewi opened this issue Mar 2, 2018 · 5 comments
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Mar 2, 2018

See #47

Background:
kubeflow/community#20

tide seems to be working for kubeflow/kubeflow.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

@BenTheElder @cjwagner Another day another repo :) Any idea what the problem is this time?

@BenTheElder
Copy link

@jlewi per the expanded merge requirements at https://prow.k8s.io/tide.html kubeflow repos need lgtm and approval. @qhuynh96 is working on a PR status page that we'll link to from the context (Eventually) to make this clearer. Looks like we just need to /lgtm

@BenTheElder
Copy link

And it just merged after I /lgtmed it :-)

@cjwagner
Copy link
Member

cjwagner commented Mar 2, 2018

/close

@jlewi
Copy link
Contributor Author

jlewi commented Mar 2, 2018

@BenTheElder thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants