Create a Docker image to use as our workers for releases. #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign jimexist |
|
FYI I created #48 to unblock this first. |
|
@jimexist tests are passing PTAL. |
|
@jimexist ping? |
|
@jlewi rebase? |
jimexist
approved these changes
Mar 2, 2018
images/Makefile
Outdated
| @@ -28,7 +30,12 @@ build: | |||
| docker tag $(IMG):$(TAG) $(IMG):latest | |||
| @echo Built $(IMG):$(TAG) and tagged with latest | |||
|
|
|||
| push: build | |||
| push: build | |||
|
/lgtm |
|
/approve |
|
/approve |
… process. We want to use a different image for security reasons because test code running in the test project could potentially modify the test worker image. To deal with kubeflow#46 remove hashes from requirements.txt
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BenTheElder, Jimexist, jlewi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jimexist
pushed a commit
to jimexist/testing
that referenced
this pull request
Mar 20, 2018
… process. (kubeflow#47) We want to use a different image for security reasons because test code running in the test project could potentially modify the test worker image. To deal with kubeflow#46 remove hashes from requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Push the CI worker image to kubeflow-releasing for use in our release process.
We want to use a different image for security reasons because test code running in the test project could potentially modify the test worker image.
To deal with Building the test worker image fails. #46 remove hashes from requirements.txt