Require name to be set for TestSuite. #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* name is used in the XMl file containing the test results. If name isn't set the XML file won't be created correctly and therefore not surfaced in gubernator correctly; see kubeflow/kubeflow#1426 * Related to kubeflow/kubeflow#1426
|
/assign @ankushagarwal |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankushagarwal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
richardsliu
pushed a commit
to richardsliu/testing
that referenced
this pull request
Sep 21, 2018
* name is used in the XMl file containing the test results. If name isn't set the XML file won't be created correctly and therefore not surfaced in gubernator correctly; see kubeflow/kubeflow#1426 * Related to kubeflow/kubeflow#1426
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name is used in the XMl file containing the test results. If name
isn't set the XML file won't be created correctly and therefore
not surfaced in gubernator correctly; see tf_job_simple_test results not being report kubeflow#1426
Related to tf_job_simple_test results not being report kubeflow#1426
This change is