Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support running multiple workflows and using a single entrypoint for prow jobs #25

Merged
merged 2 commits into from
Feb 13, 2018

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Feb 11, 2018

  • Currently each repository needs to build a new Docker container. The sole purpose of this container is to specify the path to the Argo workflow to run.

  • We can simplify this by just allowing each repository to define a "prow_config.yaml" file at the root of the repository and then having a single binary which will read that config file and use it to figure out which workflows to invoke

  • This fixes Get rid of one prow container per repo #24

  • We also add support for running multiple workflows.

  • This will make it easy to start using prow to build our containers on each commit (Build Docker images on pre/postsubmit #19)

Copy link
Contributor

@lluunn lluunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlewi jlewi merged commit d80d85c into kubeflow:master Feb 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get rid of one prow container per repo
2 participants