Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace reconciler implementation with kubeflow/common JobController #1161

Closed
Jeffwan opened this issue May 22, 2020 · 12 comments
Closed

Replace reconciler implementation with kubeflow/common JobController #1161

Jeffwan opened this issue May 22, 2020 · 12 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented May 22, 2020

In #1144, we upgrade Kubernetes to v1.16.x and update kubeflow/common to v0.3.1 which is good.
The next step, we plan to replace reconciler implementation with kubeflow/common's JobController.

in v0.3.1, I expose ReconcileJob, ReconcilePod and ReconcileService methods and if TF can not use common implementation, it's fine to override the methods and customize logic.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
feature 0.87

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@gaocegege
Copy link
Member

I think it is a high-priority feature for the next release.

/priority p1

@gaocegege
Copy link
Member

@Jeffwan

Do you have the bandwidth for this enhancement?

@Jeffwan
Copy link
Member Author

Jeffwan commented May 22, 2020

@gaocegege

Yeah. I can definitely help on that. @ChanYiLin Said he is interested in it. I will check with him and see if he's comfortable to make the change.

@gaocegege
Copy link
Member

Thanks

/assign @Jeffwan @ChanYiLin

@terrytangyuan
Copy link
Member

Any concrete plan on this yet? @Jeffwan @ChanYiLin

@ChanYiLin
Copy link
Member

I will start working on it this week, it might take 1~2 weeks
and maybe @Jeffwan can help me to check it functions well the end of next week?

@Jeffwan
Copy link
Member Author

Jeffwan commented May 27, 2020

@ChanYiLin Sounds good. Feel free to pin me for any help.

@stale
Copy link

stale bot commented Aug 27, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@terrytangyuan
Copy link
Member

terrytangyuan commented Aug 27, 2020

Should we close this now?

@stale stale bot removed the lifecycle/stale label Aug 27, 2020
@gaocegege
Copy link
Member

I think we can /cc @ChanYiLin

@ChanYiLin
Copy link
Member

Yes, we can close this now.
This issue has been resolved here #1171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants