Use go mod #1144

xychu · 2020-03-17T06:41:12Z

Try migrating to use go mod.

Including:

go mod init
go mod tidy
go mod vendor

Note: all changes are made by "go mod" tools, have not checked the versions of all the dependencies one by one.

This change is

TravisBuddy · 2020-03-17T06:42:16Z

Hey @xychu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 6f9f7120-681a-11ea-bf55-7111d60dbb66

TravisBuddy · 2020-03-17T06:45:58Z

Hey @xychu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: f43565c0-681a-11ea-bf55-7111d60dbb66

TravisBuddy · 2020-03-17T07:41:31Z

Travis tests have failed

Hey @xychu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

go build -o tf-operator.v1 github.com/kubeflow/tf-operator/cmd/tf-operator.v1

go: inconsistent vendoring in /home/travis/gopath/src/github.com/kubeflow/tf-operator:
	github.com/mattn/goveralls@v0.0.5: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory

golangci-lint run ./...

ERRO Running error: context loading failed: failed to load program with go/packages: go [list -e -json -compiled=true -test=true -export=false -deps=true -find=false -- ./...]: exit status 1: go: inconsistent vendoring in /home/travis/gopath/src/github.com/kubeflow/tf-operator:
	github.com/mattn/goveralls@v0.0.5: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory

goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"

exit status 1

TravisBuddy Request Identifier: b6593da0-6822-11ea-bf55-7111d60dbb66

coveralls · 2020-03-17T07:41:40Z

Coverage remained the same at 96.512% when pulling 72eca17 on xychu:use-go-mod into 7e06f5c on kubeflow:master.

TravisBuddy · 2020-03-17T07:46:13Z

Travis tests have failed

Hey @xychu,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

1st Build

View build log

go build -o tf-operator.v1 github.com/kubeflow/tf-operator/cmd/tf-operator.v1

go: inconsistent vendoring in /home/travis/gopath/src/github.com/kubeflow/tf-operator:
	github.com/mattn/goveralls@v0.0.5: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory

golangci-lint run ./...

ERRO Running error: context loading failed: failed to load program with go/packages: go [list -e -json -compiled=true -test=true -export=false -deps=true -find=false -- ./...]: exit status 1: go: inconsistent vendoring in /home/travis/gopath/src/github.com/kubeflow/tf-operator:
	github.com/mattn/goveralls@v0.0.5: is explicitly required in go.mod, but not marked as explicit in vendor/modules.txt

run 'go mod vendor' to sync, or use -mod=mod or -mod=readonly to ignore the vendor directory

goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/*.go,pkg/util/*/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"

exit status 1

TravisBuddy Request Identifier: 5f0182a0-6823-11ea-bf55-7111d60dbb66

gaocegege · 2020-03-17T07:51:41Z

.travis.yml


 script:
-  - hack/verify-codegen.sh


I think we should keep the verify script.

Sure, will add it back later after the code-gen related dependencies get fixed.

OK, thanks for the PR

xychu · 2020-03-18T09:23:08Z

/retest

stpabhi · 2020-03-26T23:01:25Z

@xychu is this PR ready to merge? If so, please assign an approver

xychu · 2020-03-30T10:27:27Z

@stpabhi Not yet.
While trying to fix the codegen relevant scripts, I found code-generator(https://github.com/kubernetes/code-generator/tree/v0.15.7) starts to support go mod from v0.15.7, so I've not gotten a nice way to get code-generator#kubernetes-1.12.3 into the vendor dir.
So is it okay we do some upgrade first to support kubernetes 1.15+ or add extra hack scripts to copy/move needed dependencies into vendor to make hack/verify-codegen.sh works for now?

stpabhi · 2020-04-01T20:00:20Z

@xychu I don’t see any reason not upgrading to 1.15+ kubeflow/common and kubeflow/mpi-operator use 1.15.10

Jeffwan · 2020-05-16T07:56:41Z

@xychu any progress on 1.15? We are moving to kubeflow/common in next few weeks and go module support for tf-operator is a prerequisite step. If you still work on this PR, please help upgrade to 1.15.x or 1.16.x (latest kubeflow/common uses 1.16.x).

xychu · 2020-05-18T07:25:04Z

@Jeffwan great to know kubeflow/common v0.3.1 out, will start to upgrade to 1.16.x

Update kubeflow/commmon

Also update some files with correct version

TravisBuddy · 2020-05-18T09:57:58Z

Hey @xychu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 04555100-98ee-11ea-860e-87b20eb63714

TravisBuddy · 2020-05-18T10:30:52Z

Hey @xychu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 9e378e10-98f2-11ea-860e-87b20eb63714

TravisBuddy · 2020-05-18T10:41:03Z

Hey @xychu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 04fca5d0-98f4-11ea-860e-87b20eb63714

TravisBuddy · 2020-05-18T10:56:09Z

Hey @xychu,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 1d845510-98f6-11ea-860e-87b20eb63714

Jeffwan · 2020-05-18T17:22:35Z

vendor.go

+// file from being included in builds.
+
+import (
+	_ "k8s.io/code-generator"


minor: I would suggest to put into some pkg build util.go etc rather than a separate vendor file outside.

Jeffwan · 2020-05-18T17:23:34Z

.travis.yml


 go_import_path: github.com/kubeflow/tf-operator

 install:
  # get coveralls.io support
  - go get github.com/mattn/goveralls
  - curl -sfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh| sh -s -- -b $(go env GOPATH)/bin v1.18.0
+  - go mod vendor


Any reason to vendor dependencies since this PR moves to go modules

Just thought maybe easier to go build with vendor dir, if this is not needed, I'll delete it.

I am fine to keep it now. Not a concern at this moment.

Jeffwan · 2020-05-18T23:19:17Z

/lgtm

xychu · 2020-05-19T01:36:34Z

@gaocegege @ChanYiLin plz have a look when you got time. I've updated tf-operator to use k8s 1.16.x and go mod since kubeflow/common v0.3.1 had been released out.

Jeffwan · 2020-05-19T03:51:13Z

Thanks for the PR. Once this merged, I will plan to do some more common migration, more on the controller implementation.

Jeffwan · 2020-05-21T20:30:44Z

@gaocegege @ChanYiLin Any comments on the PR? I think PR mainly upgrade kubernetes version, also upgrade kubeflow/common version to latest. (still using API but not implementation) Overall it looks good to me.

gaocegege

/approve

Thanks for your contribution! 🎉 👍

k8s-ci-robot · 2020-05-22T01:20:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [gaocegege]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the size/XXL label Mar 17, 2020

k8s-ci-robot requested review from ChanYiLin and jimexist March 17, 2020 06:41

xychu force-pushed the use-go-mod branch from 6f09b95 to 95c43e0 Compare March 17, 2020 07:47

gaocegege reviewed Mar 17, 2020

View reviewed changes

gaocegege mentioned this pull request Apr 2, 2020

migrate to go modules and update kubeflow/common apis #1151

Closed

xychu added 7 commits May 18, 2020 16:05

Update k8s to 1.16

b0f4511

Update kubeflow/commmon

godep ensure

957b226

Also update some files with correct version

Update kube-batch and apiextensions-apiserver

f353f14

Add vendor.go to include code-generator

9779ede

go mod init

04fa6a0

Update travis.yml to use go mod

09e5b06

Remove Gopkg.toml and lock file

6b8887c

xychu force-pushed the use-go-mod branch from 95c43e0 to 6b8887c Compare May 18, 2020 09:56

go mod tidy && go mod vendor

490e8ce

Add bash to run scripts

ce047d5

update codegen

49046a2

xychu added 2 commits May 18, 2020 18:59

Run go mod vendor after go get goveralls

6c868bd

re-generate after install openapi-gen

72eca17

Jeffwan reviewed May 18, 2020

View reviewed changes

k8s-ci-robot assigned Jeffwan May 18, 2020

k8s-ci-robot added the lgtm label May 18, 2020

Jeffwan approved these changes May 18, 2020

View reviewed changes

gaocegege reviewed May 22, 2020

View reviewed changes

k8s-ci-robot added the approved label May 22, 2020

k8s-ci-robot merged commit 562d50f into kubeflow:master May 22, 2020

Jeffwan mentioned this pull request May 22, 2020

Replace reconciler implementation with kubeflow/common JobController #1161

Closed

ChanYiLin mentioned this pull request Jun 17, 2020

Could not introduce k8s.io/kube-openapi@master #1174

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use go mod #1144

Use go mod #1144

xychu commented Mar 17, 2020 •

edited by jlewi

Loading

TravisBuddy commented Mar 17, 2020

TravisBuddy commented Mar 17, 2020

TravisBuddy commented Mar 17, 2020

coveralls commented Mar 17, 2020 •

edited

Loading

TravisBuddy commented Mar 17, 2020

gaocegege Mar 17, 2020

xychu Mar 17, 2020

gaocegege Mar 17, 2020

xychu commented Mar 18, 2020

stpabhi commented Mar 26, 2020

xychu commented Mar 30, 2020

stpabhi commented Apr 1, 2020

Jeffwan commented May 16, 2020

xychu commented May 18, 2020

TravisBuddy commented May 18, 2020

TravisBuddy commented May 18, 2020

TravisBuddy commented May 18, 2020

TravisBuddy commented May 18, 2020

Jeffwan May 18, 2020

Jeffwan May 18, 2020

xychu May 19, 2020

Jeffwan May 19, 2020

Jeffwan commented May 18, 2020

xychu commented May 19, 2020

Jeffwan commented May 19, 2020

Jeffwan commented May 21, 2020

gaocegege left a comment

k8s-ci-robot commented May 22, 2020

Use go mod #1144

Use go mod #1144

Conversation

xychu commented Mar 17, 2020 • edited by jlewi Loading

TravisBuddy commented Mar 17, 2020

TravisBuddy Request Identifier: 6f9f7120-681a-11ea-bf55-7111d60dbb66

TravisBuddy commented Mar 17, 2020

TravisBuddy Request Identifier: f43565c0-681a-11ea-bf55-7111d60dbb66

TravisBuddy commented Mar 17, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: b6593da0-6822-11ea-bf55-7111d60dbb66

coveralls commented Mar 17, 2020 • edited Loading

TravisBuddy commented Mar 17, 2020

Travis tests have failed

1st Build

TravisBuddy Request Identifier: 5f0182a0-6823-11ea-bf55-7111d60dbb66

gaocegege Mar 17, 2020

Choose a reason for hiding this comment

xychu Mar 17, 2020

Choose a reason for hiding this comment

gaocegege Mar 17, 2020

Choose a reason for hiding this comment

xychu commented Mar 18, 2020

stpabhi commented Mar 26, 2020

xychu commented Mar 30, 2020

stpabhi commented Apr 1, 2020

Jeffwan commented May 16, 2020

xychu commented May 18, 2020

TravisBuddy commented May 18, 2020

TravisBuddy Request Identifier: 04555100-98ee-11ea-860e-87b20eb63714

TravisBuddy commented May 18, 2020

TravisBuddy Request Identifier: 9e378e10-98f2-11ea-860e-87b20eb63714

TravisBuddy commented May 18, 2020

TravisBuddy Request Identifier: 04fca5d0-98f4-11ea-860e-87b20eb63714

TravisBuddy commented May 18, 2020

TravisBuddy Request Identifier: 1d845510-98f6-11ea-860e-87b20eb63714

Jeffwan May 18, 2020

Choose a reason for hiding this comment

Jeffwan May 18, 2020

Choose a reason for hiding this comment

xychu May 19, 2020

Choose a reason for hiding this comment

Jeffwan May 19, 2020

Choose a reason for hiding this comment

Jeffwan commented May 18, 2020

xychu commented May 19, 2020

Jeffwan commented May 19, 2020

Jeffwan commented May 21, 2020

gaocegege left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented May 22, 2020

xychu commented Mar 17, 2020 •

edited by jlewi

Loading

coveralls commented Mar 17, 2020 •

edited

Loading