Code restructuring

[johnugeorge]

I am little confused with the code structure

With recent changes,

1. We have duplicated jobcontroller in common package. However, v1beta1 code still uses controller.v2 job controller. (https://github.com/kubeflow/tf-operator/blob/master/pkg/controller.v1beta1/tensorflow/pod.go#L29)

2. Files in https://github.com/kubeflow/tf-operator/tree/master/pkg/common/util are specific to TF and its version. ( eg: https://github.com/kubeflow/tf-operator/blob/master/pkg/common/util/unstructured/informer.go#L16) Does the util folder need to be in common folder?

/assign @richardsliu

[gaocegege]

Files in https://github.com/kubeflow/tf-operator/tree/master/pkg/common/util are specific to TF and its version. ( eg: https://github.com/kubeflow/tf-operator/blob/master/pkg/common/util/unstructured/informer.go#L16) Does the util folder need to be in common folder?

I think so.

[richardsliu]

1 is my mistake, it should be using the common package.

For 2, maybe we can move util under controller.v1beta1?

[richardsliu]

@johnugeorge Anything else needed here?

[johnugeorge]

2 is not done yet. But we can take it up in a separate PR when we move to a new version later

[johnugeorge]

/close

[k8s-ci-robot]

@johnugeorge: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.