MasterRole label initialization

[johnugeorge]

@terrytangyuan I see that masterRole re-initialization is removed inside loop in your PR https://github.com/kubeflow/tf-operator/pull/974/files#diff-ec57988f58453ac8c08d62d32e48e0a2L76

If masterRole is not re-initialized inside loop, every pod will have master role to be true once it has got set . What is the reason behind this?

/cc @terrytangyuan

[issue-label-bot]

Issue Label Bot is not confident enough to auto-label this issue. See dashboard for more details.

[terrytangyuan]

@johnugeorge I changed it only from a programmatic/lint perspective, the default value for bool is false in Go so masterRole = false isn't really necessary anymore.

[johnugeorge]

@terrytangyuan masterRole = false is inside a loop and masterRole is set only for the pod where it acts as master

[terrytangyuan]

@johnugeorge Good catch. I am reverting it in #992. Thanks!