Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easily detect the GOPATH in current development environment. #1047

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

xauthulei
Copy link
Member

@xauthulei xauthulei commented Jul 19, 2019

It will be useful to a new go developer and also easy to detect the GOPATH in different go env.


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @xauthulei. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling 8829fad on xauthulei:dev into eb02785 on kubeflow:master.

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit d01ec32 into kubeflow:master Jul 19, 2019
@xauthulei xauthulei deleted the dev branch July 19, 2019 03:22
@gaocegege
Copy link
Member

@xauthulei

Thanks for your contribution. Welcome more contributions!

@xauthulei
Copy link
Member Author

@gaocegege ,Yea, it's really my honor, and I will. Thanks for your great review efforts here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants