Add verify-codegen in travis CI #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ohmystack. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Mentioned here: #1069 (comment) |
gaocegege
reviewed
Aug 16, 2019
.travis.yml
Outdated
| @@ -24,6 +24,7 @@ script: | |||
| # And we can not use ** because goveralls uses filepath.Match | |||
| # to match ignore files and it does not support it. | |||
| - goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go" | |||
| - hack/verify-codegen.sh | |||
There was a problem hiding this comment.
Can we verify the codegen before the go build commands? Since it can fail fast.
There was a problem hiding this comment.
It makes sense. Done.
|
/ok-to-test Thanks for your contribution! 🎉 👍 |
ohmystack
force-pushed
the
travis-verify-codegen
branch
from
9783e39
to
9f8adfc
Compare
Travis tests have failedHey @ohmystack, 1st Buildgoveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"hack/verify-codegen.shTravisBuddy Request Identifier: 82fb0eb0-c00d-11e9-aed2-2b81c1e31580 |
Travis tests have failedHey @ohmystack, 1st Buildhack/verify-codegen.shgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: 764b6b00-c00e-11e9-aed2-2b81c1e31580 |
|
@gaocegege #1069 is merged. It's ok to rerun the test now |
|
@ohmystack Can you rebase the master? |
ohmystack
force-pushed
the
travis-verify-codegen
branch
from
9f8adfc
to
2b5c13a
Compare
Done. |
Travis tests have failedHey @ohmystack, 1st Buildhack/verify-codegen.shgoveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: 8562d4d0-c25b-11e9-86a4-77838e0d0b7a |
|
hack/../hack/update-codegen.sh: line 49: /home/travis/gopath/bin/openapi-gen: No such file or directory Maybe the error is caused by the path |
|
@gaocegege Thanks for helping debuging. |
|
/lgtm Though this is a workaround, I do not have a better idea, too. Thus LGTM Thanks for your contribution! 🎉 👍 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is