Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating issue bot configs #1074

Merged
merged 1 commit into from Sep 5, 2019
Merged

Conversation

rbrishabh
Copy link
Contributor

@rbrishabh rbrishabh commented Aug 29, 2019

With regards to issue 440 of kubeflow/testing , issue bot configs need to be updated to use kind labels.
@jlewi


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @rbrishabh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.744% when pulling b045869 on rbrishabh:patch-1 into bcd7e70 on kubeflow:master.

@gaocegege
Copy link
Member

/ok-to-test

@rbrishabh
Copy link
Contributor Author

/assign jlewi

@rbrishabh
Copy link
Contributor Author

/assign abhi-g

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@abhi-g
Copy link
Member

abhi-g commented Aug 30, 2019

/ok-to-test
ok-to-tes

@abhi-g
Copy link
Member

abhi-g commented Aug 30, 2019 via email

@jlewi
Copy link
Contributor

jlewi commented Sep 4, 2019

/lgtm
/approve

@rbrishabh
Copy link
Contributor Author

rbrishabh commented Sep 4, 2019

/assign gaocegege

@jlewi
Copy link
Contributor

jlewi commented Sep 4, 2019

/assign @richardsliu
@richardsliu Can you approve this please?

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

@k8s-ci-robot k8s-ci-robot merged commit 18aeadc into kubeflow:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants