Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes #899

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Minor fixes #899

merged 1 commit into from
Dec 19, 2018

Conversation

johnugeorge
Copy link
Member

@johnugeorge johnugeorge commented Dec 19, 2018

Fix has been ported to v1beta1 code.

Initial PR: #890


This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 64.856% when pulling 54491c3 on johnugeorge:minorfixes into 451069f on kubeflow:master.

@gaocegege
Copy link
Member

/retest

3 similar comments
@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

/retest

@johnugeorge
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f9d5f1e into kubeflow:master Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants