bug: get condition just get last, should get special type condition

kubeflow · Dec 11, 2018 · 05af3fb · 05af3fb
1 parent 1abc120
commit 05af3fb
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/controller.v2/tensorflow/status.go b/pkg/controller.v2/tensorflow/status.go
@@ -176,8 +176,10 @@ func newCondition(conditionType tfv1alpha2.TFJobConditionType, reason, message s
 
 // getCondition returns the condition with the provided type.
 func getCondition(status tfv1alpha2.TFJobStatus, condType tfv1alpha2.TFJobConditionType) *tfv1alpha2.TFJobCondition {
-	if len(status.Conditions) > 0 {
-		return &status.Conditions[len(status.Conditions)-1]
+	for _, condition := range status.Conditions {
+		if condition.Type == condType {
+			return &condition
+		}
 	}
 	return nil
 }