-
Notifications
You must be signed in to change notification settings - Fork 664
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix comments for mpi-controller (#1485)
fix comments for mpi-controller fix controller-related comments for mpijob fix comments for mpi-controller Co-authored-by: hackerboy01 <penglei031303@gmail.com>
- Loading branch information
1 parent
f894870
commit 71428d5
Showing
5 changed files
with
107 additions
and
64 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| // Copyright 2021 The Kubeflow Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package validation | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| commonv1 "github.com/kubeflow/common/pkg/apis/common/v1" | ||
| mpiv1 "github.com/kubeflow/training-operator/pkg/apis/mpi/v1" | ||
|
|
||
| v1 "k8s.io/api/core/v1" | ||
| ) | ||
|
|
||
| func TestValidateV1MpiJobSpec(t *testing.T) { | ||
| testCases := []mpiv1.MPIJobSpec{ | ||
| { | ||
| MPIReplicaSpecs: nil, | ||
| }, | ||
| { | ||
| MPIReplicaSpecs: map[commonv1.ReplicaType]*commonv1.ReplicaSpec{ | ||
| mpiv1.MPIReplicaTypeLauncher: &commonv1.ReplicaSpec{ | ||
| Template: v1.PodTemplateSpec{ | ||
| Spec: v1.PodSpec{ | ||
| Containers: []v1.Container{}, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| MPIReplicaSpecs: map[commonv1.ReplicaType]*commonv1.ReplicaSpec{ | ||
| mpiv1.MPIReplicaTypeLauncher: &commonv1.ReplicaSpec{ | ||
| Template: v1.PodTemplateSpec{ | ||
| Spec: v1.PodSpec{ | ||
| Containers: []v1.Container{ | ||
| v1.Container{ | ||
| Image: "", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| MPIReplicaSpecs: map[commonv1.ReplicaType]*commonv1.ReplicaSpec{ | ||
| mpiv1.MPIReplicaTypeLauncher: &commonv1.ReplicaSpec{ | ||
| Template: v1.PodTemplateSpec{ | ||
| Spec: v1.PodSpec{ | ||
| Containers: []v1.Container{ | ||
| v1.Container{ | ||
| Name: "", | ||
| Image: "kubeflow/tf-dist-mnist-test:1.0", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| MPIReplicaSpecs: map[commonv1.ReplicaType]*commonv1.ReplicaSpec{ | ||
| mpiv1.MPIReplicaTypeLauncher: &commonv1.ReplicaSpec{ | ||
| Replicas: mpiv1.Int32(2), | ||
| Template: v1.PodTemplateSpec{ | ||
| Spec: v1.PodSpec{ | ||
| Containers: []v1.Container{ | ||
| v1.Container{ | ||
| Name: "tensorflow", | ||
| Image: "kubeflow/tf-dist-mnist-test:1.0", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| } | ||
| for _, c := range testCases { | ||
| err := ValidateV1MpiJobSpec(&c) | ||
| if err == nil { | ||
| t.Error("Failed validate the v1.MpiJobSpec") | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters