Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks in the "Overview" section is incorrect/not found #1411

Closed
pramodrj07 opened this issue Sep 20, 2021 · 5 comments
Closed

Hyperlinks in the "Overview" section is incorrect/not found #1411

pramodrj07 opened this issue Sep 20, 2021 · 5 comments

Comments

@pramodrj07
Copy link
Contributor

pramodrj07 commented Sep 20, 2021

The hyperlinks in the overview section do not work. This is for the API Definition to the custom resource definitions of TensorFlow, Pytorch, MXNet, and XGBoost

https://github.com/kubeflow/tf-operator#overview

@Jeffwan
Copy link
Member

Jeffwan commented Sep 21, 2021

@pramodrj07 Thanks for reporting the issue. It should be https://github.com/kubeflow/tf-operator/blob/master/pkg/apis/xgboost/v1/xgboostjob_types.go.

If you have time to file a PR to fix them, that would be great!

/help
/good-first-issue

@google-oss-robot
Copy link

@Jeffwan:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

@pramodrj07 Thanks for reporting the issue. It should be https://github.com/kubeflow/tf-operator/blob/master/pkg/apis/xgboost/v1/xgboostjob_types.go.

If you have time to file a PR to fix them, that would be great!

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jeffwan
Copy link
Member

Jeffwan commented Sep 21, 2021

/bug

@pramodrj07
Copy link
Contributor Author

Hi @Jeffwan - Yes, I will file a PR for this fix this

pramodrj07 added a commit to pramodrj07/internal-acls that referenced this issue Sep 21, 2021
pramodrj07 added a commit to pramodrj07/tf-operator that referenced this issue Sep 22, 2021
hyperlinks now point to the latest api reference files.
issue - kubeflow#1411
google-oss-robot pushed a commit that referenced this issue Sep 29, 2021
hyperlinks now point to the latest api reference files.
issue - #1411
Jeffwan pushed a commit to Jeffwan/tf-operator that referenced this issue Oct 3, 2021
hyperlinks now point to the latest api reference files.
issue - kubeflow#1411
Jeffwan added a commit to Jeffwan/tf-operator that referenced this issue Oct 3, 2021
hyperlinks now point to the latest api reference files.
issue - kubeflow#1411
google-oss-robot pushed a commit that referenced this issue Oct 3, 2021
* Feature/support pytorchjob set queue of volcano (#1415)

* support pytorch use volcano-queue

* support pytorch use volcano-queue

Signed-off-by: bert.li <qiankun.li@qq.com>

* set SchedulingPolicy for runPolicy

Signed-off-by: bert.li <qiankun.li@qq.com>

* use pytorchjob.Spec.RunPolicy directly

* fix hyperlinks in the 'overview' section (#1418)

hyperlinks now point to the latest api reference files.
issue - #1411
@stale
Copy link

stale bot commented Mar 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Mar 2, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants