Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of worker threads used by the controller can't be configured #1706

Closed
HeGaoYuan opened this issue Dec 23, 2022 · 0 comments
Closed

Number of worker threads used by the controller can't be configured #1706

HeGaoYuan opened this issue Dec 23, 2022 · 0 comments

Comments

@HeGaoYuan
Copy link
Contributor

HeGaoYuan commented Dec 23, 2022

As the following log shows, the default number of worker threads used by controller is 1. This value is too small for production environment because it will cause extremely delay of processing Job if there are many Jobs at the same time.

And I found this can't be configured.

1.6717679978118246e+09  INFO    Starting workers        {"controller": "pytorchjob-controller", "worker count": 1}
1.6717679978129413e+09  INFO    Starting workers        {"controller": "tfjob-controller", "worker count": 1}
1.6717679978130171e+09  INFO    Starting workers        {"controller": "mpijob-controller", "worker count": 1}

Referring to point4 of #1703

HeGaoYuan added a commit to HeGaoYuan/training-operator that referenced this issue Dec 23, 2022
HeGaoYuan added a commit to HeGaoYuan/training-operator that referenced this issue Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant