Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures aren't properly reported in Gubernator #229

Closed
jlewi opened this issue Dec 14, 2017 · 2 comments
Closed

Test failures aren't properly reported in Gubernator #229

jlewi opened this issue Dec 14, 2017 · 2 comments

Comments

@jlewi
Copy link
Contributor

jlewi commented Dec 14, 2017

If steps in our Airflow E2E test pipeline fail, we should create junit files in GCS so that gubernator shows the test as failed.

Similarly, we should probably create junit files corresponding to any steps that don't run because of upstream failures.

Otherwise in Gubernator if a step fails we just see 0 failed/ N succeeded where N is less than the total number of tests. This is confusing for people looking at the tests.

One way to fix this would be to have the final step in our Airflow pipeline create any missing junit files in gubernator.

context:
#222 (comment)

@jlewi
Copy link
Contributor Author

jlewi commented Jan 25, 2018

This has been fixed.

@jlewi jlewi closed this as completed Jan 25, 2018
@jlewi
Copy link
Contributor Author

jlewi commented Feb 12, 2018

This was addressed by #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant