-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take test failures into account when setting prow job status #319
Conversation
* Test failures weren't being properly reported to gubernator because we had the wrong XML format. We need to use a nested failure tag and specify the message inside the tag.
Someone want to take a look at this before I commit? This should allow us to fully trust test results so we can reenable the releaser. |
parser_finished.set_defaults(func=finalize_prow_job) | ||
|
||
# parse the args and call whatever function was selected | ||
args = parser.parse_args() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about replacing it with args, _ = parser.parse_known_args()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why would we want to silently ignore unknown arguments? There should be no unknown arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also make sense to set a strict parser as the current design.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
parser_finished.set_defaults(func=finalize_prow_job) | ||
|
||
# parse the args and call whatever function was selected | ||
args = parser.parse_args() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also make sense to set a strict parser as the current design.
Travis seems to be having problems running the build but since our presubmits are passing I'm going to merge this. |
When setting prow job status, we want to look at the junit files and see if there were any test failures. Otherwise the k8s robot will report the tests as succeeding even when there were failures.
Fix Need to mark prow job as failed if any tests fail #315
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)