-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support pprof when monitoring is specified #1102
Conversation
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Hey @gaocegege, TravisBuddy Request Identifier: 3d0ce520-101e-11ea-a65a-5f455ab5a299 |
/retest |
2 similar comments
/retest |
/retest |
how do you plan to use pprof in tf-operator ? |
It may be helpful when we need to locate some performance issues. I think the metrics endpoint and ppof endpoint should be disabled by default. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reuse the Prometheus metrics port to expose golang pprof info.
/assign @johnugeorge @hougangliu
Signed-off-by: Ce Gao gaoce@caicloud.io
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)