Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add distributed training example of using TF 2.1 Strategy API #1164

Merged
merged 2 commits into from
May 24, 2020
Merged

add distributed training example of using TF 2.1 Strategy API #1164

merged 2 commits into from
May 24, 2020

Conversation

jazzsir
Copy link
Contributor

@jazzsir jazzsir commented May 22, 2020

. add multi-worker strategy example to keras-API directory.
. move existing strategy example to estimator-API directory, to distinguish strategy examples.

Fixes #953

. add multi-worker strategy example to keras-API directory.
. move existing strategy example to estimator-API directory, to distinguish strategy examples.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kubeflow-bot
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link

Hi @jazzsir. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jazzsir
Copy link
Contributor Author

jazzsir commented May 22, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@coveralls
Copy link

coveralls commented May 22, 2020

Coverage Status

Coverage remained the same at 96.512% when pulling adbc60f on jazzsir:master into 562d50f on kubeflow:master.

. This example was moved to estimator-API directory
@gaocegege
Copy link
Member

/ok-to-test

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for your contribution! 🎉 👍

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 07baabf into kubeflow:master May 24, 2020
@jinchihe jinchihe mentioned this pull request Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create distributed training example for TF 2.0
6 participants