Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove Github CD workflow #1263

Merged
merged 1 commit into from Mar 29, 2021

Conversation

PatrickXYS
Copy link
Member

Resolves #1262

Since we migrated to public ECR for release purpose, we can remove existing github action CD workflow

/cc @gaocegege @Jeffwan

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.479% when pulling 2db632a on PatrickXYS:rm_actions into f564bce on kubeflow:master.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PatrickXYS PatrickXYS changed the title Remove Github CD workflow Fix: Remove Github CD workflow Mar 28, 2021
@gaocegege
Copy link
Member

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, Jeffwan, PatrickXYS, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 8d179f7 into kubeflow:master Mar 29, 2021
@PatrickXYS PatrickXYS deleted the rm_actions branch March 29, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions runs failed
6 participants