Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing retrying package that failed the import #1439

Merged
merged 1 commit into from
Oct 8, 2021

Conversation

terrytangyuan
Copy link
Member

This fixes the following error:

>>> from kubeflow import training
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/opt/homebrew/lib/python3.9/site-packages/kubeflow/training/__init__.py", line 49, in <module>
    from kubeflow.training.api.tf_job_client import TFJobClient
  File "/opt/homebrew/lib/python3.9/site-packages/kubeflow/training/api/tf_job_client.py", line 26, in <module>
    from .tf_job_watch import watch as tfjob_watch
  File "/opt/homebrew/lib/python3.9/site-packages/kubeflow/training/api/tf_job_watch.py", line 15, in <module>
    import retrying
ModuleNotFoundError: No module named 'retrying'

Signed-off-by: Yuan Tang terrytangyuan@gmail.com

Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
@Jeffwan
Copy link
Member

Jeffwan commented Oct 7, 2021

@terrytangyuan You install the package from master branch?

@Jeffwan
Copy link
Member

Jeffwan commented Oct 7, 2021

/hold
/lgtm

@terrytangyuan
Copy link
Member Author

@terrytangyuan You install the package from master branch?

Yes

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for your contribution! 🎉 👍

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, Jeffwan, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member Author

/unhold

@google-oss-robot google-oss-robot merged commit f45ba08 into kubeflow:master Oct 8, 2021
@terrytangyuan terrytangyuan deleted the fix-missing-pkg branch October 8, 2021 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants