Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set scheduler error #1448

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

qiankunli
Copy link
Contributor

Signed-off-by: bert.li qiankun.li@qq.com
fix issue #1447

Signed-off-by: bert.li <qiankun.li@qq.com>
@aws-kf-ci-bot
Copy link
Contributor

Hi @qiankunli. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: qiankunli
To complete the pull request process, please assign johnugeorge after the PR has been reviewed.
You can assign the PR to them by writing /assign @johnugeorge in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/ok-to-test

@coveralls
Copy link

coveralls commented Oct 14, 2021

Pull Request Test Coverage Report for Build 1421229485

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 62 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 8.15%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 62 0%
Totals Coverage Status
Change from base Build 1324313686: -0.01%
Covered Lines: 311
Relevant Lines: 3816

💛 - Coveralls

Copy link
Member

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment here

#1447 (comment)

@Jeffwan Jeffwan changed the title [fix]fix set scheduler error Fix set scheduler error Nov 4, 2021
Signed-off-by: bert.li <qiankun.li@qq.com>
@google-oss-prow google-oss-prow bot added size/S and removed size/XS labels Nov 4, 2021
Copy link
Member

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is clear and thanks for the change

@Jeffwan
Copy link
Member

Jeffwan commented Nov 4, 2021

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jeffwan, qiankunli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 1a69a5e into kubeflow:master Nov 4, 2021
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! 🎉 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants