Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tfjob status when enableDynamicWorker set true #1455

Merged
merged 1 commit into from
Oct 29, 2021
Merged

fix tfjob status when enableDynamicWorker set true #1455

merged 1 commit into from
Oct 29, 2021

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Oct 28, 2021 •
edited

Addressing #1452
this fix checks before setting tfjob to Failed against the enableDynamicWorker field when replicaType is Worker.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Oct 28, 2021 •
edited

Pull Request Test Coverage Report for Build 1397792808

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 8.152%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 0 4 0.0%
Totals Coverage Status
Change from base Build 1388260454: -0.009%
Covered Lines: 311
Relevant Lines: 3815
💛 - Coveralls

gaocegege
gaocegege reviewed Oct 29, 2021
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-robot google-oss-robot merged commit 9efffd4 into kubeflow:master Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@jinchihe jinchihe Awaiting requested review from jinchihe

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@zw0610 @google-oss-robot @coveralls @terrytangyuan @gaocegege