Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update OWNERS #1489

Merged
merged 1 commit into from
Dec 1, 2021
Merged

chore: Update OWNERS #1489

merged 1 commit into from
Dec 1, 2021

Conversation

gaocegege
Copy link
Member

@gaocegege gaocegege commented Nov 26, 2021

Add @zw0610 as the approver.

Lucas helped to improve the kubeflow common and migrated mpi and pytorch to the training operator. I suggest adding him as an approver in training operator.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Add @zw0610 as the owner.

- https://github.com/kubeflow/training-operator/commits?author=zw0610
- https://github.com/kubeflow/common/commits?author=zw0610

Lucas helped to improve the kubeflow common and migrated mpi and pytorch to the training operator. I suggest adding him as an approver in training operator.
@gaocegege
Copy link
Member Author

/cc @kubeflow/wg-training-leads /cc @zw0610

@google-oss-prow google-oss-prow bot requested a review from a team November 26, 2021 06:41
@google-oss-prow
Copy link

@gaocegege: GitHub didn't allow me to request PR reviews from the following users: /cc.

Note that only kubeflow members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @kubeflow/wg-training-leads /cc @zw0610

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1506458901

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 26.843%

Totals Coverage Status
Change from base Build 1506446782: 0.2%
Covered Lines: 1613
Relevant Lines: 6009

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @zw0610 for your contributions! Let’s wait a bit for feedback from others since it’s Thanksgiving break.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gaocegege,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@terrytangyuan
Copy link
Member

/hold

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great work and help @zw0610!
/lgtm

@gaocegege
Copy link
Member Author

/cc @Jeffwan

@johnugeorge
Copy link
Member

Thanks @zw0610
/lgtm

@Jeffwan
Copy link
Member

Jeffwan commented Dec 1, 2021

/lgtm

@zw0610 devotes lots of his energy to this project. Great to have him here.

@gaocegege
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 84a48dc into master Dec 1, 2021
@gaocegege gaocegege deleted the gaocegege-patch-1 branch December 1, 2021 02:48
@terrytangyuan
Copy link
Member

@zw0610 Congrats and welcome!

@zw0610
Copy link
Member

zw0610 commented Dec 1, 2021

Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants