add StacktraceLevel for zapr #1512
Conversation
|
Hi @qiankunli. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
cmd/training-operator.v1/main.go
Outdated
| @@ -19,6 +19,7 @@ package main | |||
| import ( | |||
| "flag" | |||
| "fmt" | |||
| "go.uber.org/zap/zapcore" | |||
There was a problem hiding this comment.
Please move this import statement to the second group.
cmd/training-operator.v1/main.go
Outdated
| @@ -33,6 +33,7 @@ import ( | |||
| ctrl "sigs.k8s.io/controller-runtime" | |||
| "sigs.k8s.io/controller-runtime/pkg/healthz" | |||
| "sigs.k8s.io/controller-runtime/pkg/log/zap" | |||
| "go.uber.org/zap/zapcore" | |||
|
|
|||
| mpiv1 "github.com/kubeflow/training-operator/pkg/apis/mpi/v1" | |||
| mxnetv1 "github.com/kubeflow/training-operator/pkg/apis/mxnet/v1" | |||
There was a problem hiding this comment.
The indentation for the import statements are not correct
There was a problem hiding this comment.
@terrytangyuan ok, go fmt
|
Please sign the CLA and pass the test cases. Thanks! |
Pull Request Test Coverage Report for Build 1626572853
💛 - Coveralls |
qiankunli
force-pushed
the
fixzapr
branch
4 times, most recently
from
71ba8a9
to
f9e6525
Compare
Signed-off-by: qiankunli <bert.li.qiankun@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiankunli, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
the same problem as: kubernetes-sigs/kubebuilder#1593