Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused scripts #1521

Merged
merged 1 commit into from
Jan 15, 2022
Merged

remove unused scripts #1521

merged 1 commit into from
Jan 15, 2022

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Jan 9, 2022

improve status_test from tensorflow

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • remove unused code
  • revert SetServicesV2 back to SetServices
  • add test code for register_controller.go

improve status_test from tensorflow
@aws-kf-ci-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1673998083

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 37.002%

Totals Coverage Status
Change from base Build 1660952137: 0.3%
Covered Lines: 2283
Relevant Lines: 6170

💛 - Coveralls

@zw0610 zw0610 marked this pull request as ready for review January 9, 2022 13:34
@@ -17,8 +17,6 @@ package v1
import common "github.com/kubeflow/common/pkg/apis/common/v1"

const (
// EnvKubeflowNamespace is ENV for kubeflow namespace specified by user.
EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember this was the default. So this isn't used anywhere anymore?

Copy link
Member Author

@zw0610 zw0610 Jan 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems not. Let's see scripts below:

lucas@Wangs-MacBook-Pro-at-Tencent > /tmp/training-operator-master > grep -rin "KUBEFLOW_NAMESPACE" .
./docs/development/developer_guide.md:47:### Configure KUBECONFIG and KUBEFLOW_NAMESPACE
./docs/development/developer_guide.md:54:export KUBEFLOW_NAMESPACE=$(your_namespace)
./docs/development/developer_guide.md:57:- KUBEFLOW_NAMESPACE is used when deployed on Kubernetes, we use this variable to create other resources (e.g. the resource lock) internal in the same namespace. It is optional, use `default` namespace if not set.
./pkg/apis/mpi/v1/constants.go:21:	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
./pkg/common/constants.go:19:	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"

 lucas@Wangs-MacBook-Pro-at-Tencent > /tmp/training-operator-master > grep -rin "EnvKubeflowNamespace" .
./pkg/apis/mpi/v1/constants.go:20:	// EnvKubeflowNamespace is ENV for kubeflow namespace specified by user.
./pkg/apis/mpi/v1/constants.go:21:	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"
./pkg/common/constants.go:18:	// EnvKubeflowNamespace is ENV for kubeflow namespace specified by user.
./pkg/common/constants.go:19:	EnvKubeflowNamespace = "KUBEFLOW_NAMESPACE"

I double checked with v1.2.0 and EnvKubeflowNamespace is used there. It seems the transition results in a change in the main function, which lost this option. But we can still remove it here as it's also defined in the kubeflow/common library: https://github.com/kubeflow/common/blob/97658773cce10b2b706e38858e48137ae370ed10/pkg/util/util.go#L31

I open another issue to restore these options: #1522

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [terrytangyuan,zw0610]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4ebd16b into kubeflow:master Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants