Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore option namespace in launch arguments #1524

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

zw0610
Copy link
Member

@zw0610 zw0610 commented Jan 15, 2022

What this PR does / why we need it:

Restore the launch argument --namespace to allow user to specify namespace to monitor

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1522

Checklist:

@coveralls
Copy link

coveralls commented Jan 15, 2022

Pull Request Test Coverage Report for Build 1703120409

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 36.823%

Totals Coverage Status
Change from base Build 1701643908: 0.0%
Covered Lines: 2272
Relevant Lines: 6170

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update PR title to be descriptive and fix imports

@zw0610 zw0610 changed the title Fix options restore option namespace in launch arguments Jan 16, 2022
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan, zw0610

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [terrytangyuan,zw0610]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 51d6385 into kubeflow:master Jan 16, 2022
@zw0610 zw0610 deleted the fix-options branch June 20, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore KUBEFLOW_NAMESPACE options
3 participants