Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifests with latest image tag #1527

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Update manifests with latest image tag #1527

merged 5 commits into from
Jan 26, 2022

Conversation

johnugeorge
Copy link
Member

No description provided.

@johnugeorge
Copy link
Member Author

/assign @terrytangyuan
/assign @gaocegege

terrytangyuan
terrytangyuan approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jan 26, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1752524607

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 36.856%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 5 75.54%
Totals Coverage Status
Change from base Build 1723921640: -0.02%
Covered Lines: 2274
Relevant Lines: 6170
💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit c935698 into kubeflow:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@gaocegege gaocegege Awaiting requested review from gaocegege

@jinchihe jinchihe Awaiting requested review from jinchihe

Assignees

@terrytangyuan terrytangyuan

@gaocegege gaocegege

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnugeorge @coveralls @terrytangyuan @gaocegege