mod: Upgrade ginkgo to v2 #1537
Conversation
|
Hi @haoxins. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
google-oss-prow
bot
requested review from
jinchihe,
terrytangyuan and
zw0610
|
/ok-to-test |
|
@haoxins: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Pull Request Test Coverage Report for Build 2493198613
💛 - Coveralls |
|
/hold till #1610 is merged |
|
/hold cancel |
|
@haoxins, Can you please resolve merge conflicts? |
fix conflict
done |
| @@ -93,7 +90,7 @@ var _ = BeforeSuite(func() { | |||
| err = mgr.Start(testCtx) | |||
| Expect(err).ToNot(HaveOccurred(), "failed to run manager") | |||
| }() | |||
| }, 60) | |||
There was a problem hiding this comment.
@haoxins Was the timeout feature removed in ginkgo/v2?
There was a problem hiding this comment.
https://onsi.github.io/ginkgo/MIGRATING_TO_V2#removed-async-testing
Maybe we can take the Asynchronous Assertions
There was a problem hiding this comment.
@haoxins Thanks for clarifying!
Do you @kubeflow/wg-training-leads want to fix the suite test with this PR?
There was a problem hiding this comment.
@tenzen-y Yes. Can you give LGTM?
There was a problem hiding this comment.
@johnugeorge Sorry if I've confused you.
This PR disables timeout to adapt ginkgo v2. This way is a workaround.
If we adopt the suite test entirely to ginkgo v2, we need to fix the suite test code to use Asynchronous Assertions as described above.
There was a problem hiding this comment.
So, I would like to know even if you would like to switch to suite testing with asynchronous assertions in this PR.
There was a problem hiding this comment.
Yes. I meant, we can switch if there are no other concerns.
Since BeforeSuite didn't use any Done channel, i assume that it is sill using synchronous execution and timeout is not enforced. See onsi/ginkgo#882 (comment) .
Did you mean, we have other places in test code where we used timeouts? I see that tests are passing.
There was a problem hiding this comment.
Since BeforeSuite didn't use any Done channel, i assume that it is sill using synchronous execution and timeout is not enforced. See onsi/ginkgo#882 (comment) .
I had missed that issue comment. Thanks, @johnugeorge.
LGTM
There was a problem hiding this comment.
@haoxins Any other changes required here to migrate to new version?
There was a problem hiding this comment.
I think no more changes required.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoxins, johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Just upgrade the ginkgo into v2