Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go version to v1.19 #1663

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

tenzen-y
Copy link
Member

Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I upgraded the Go version to v1.19.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Sep 18, 2022

Pull Request Test Coverage Report for Build 3077780557

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 39.853%

Totals Coverage Status
Change from base Build 3069782009: 0.05%
Covered Lines: 2333
Relevant Lines: 5854

💛 - Coveralls

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
@johnugeorge
Copy link
Member

/lgtm

@tenzen-y
Copy link
Member Author

@johnugeorge Also, we need to add /approve.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 54a408f into kubeflow:master Sep 21, 2022
@tenzen-y tenzen-y deleted the upgrade-go-version branch September 22, 2022 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants