Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed GOARCH dependency for multiarch support #1674

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

pranavpandit1
Copy link
Contributor

These changes are targeted to remove the arch-specific dependency.
Also, these changes are verified for Intel and ppc64le.

@gaocegege
Copy link
Member

Thanks for your contribution! 🎉 👍

/lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3271684338

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 17 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-21.6%) to 18.354%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 8 77.46%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 61.81%
Totals Coverage Status
Change from base Build 3132871820: -21.6%
Covered Lines: 281
Relevant Lines: 1531

💛 - Coveralls

@johnugeorge
Copy link
Member

/cc @tenzen-y

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@johnugeorge
Copy link
Member

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, pranavpandit1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants