Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a generic logger instead of the nil logger on dependent update #1680

Merged
merged 3 commits into from
Nov 4, 2022

Conversation

ggaaooppeenngg
Copy link
Contributor

Signed-off-by: Peng Gao peng.gao.dut@gmail.com

What this PR does / why we need it:

Make a temporary logger for generic object instead of being nil.

Which issue(s) this PR fixes

Fixes #1679 #1678

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
@coveralls
Copy link

coveralls commented Nov 2, 2022

Pull Request Test Coverage Report for Build 3392042555

  • 0 of 30 (0.0%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 39.932%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller.v1/mxnet/mxjob_controller.go 0 3 0.0%
pkg/controller.v1/pytorch/pytorchjob_controller.go 0 3 0.0%
pkg/controller.v1/tensorflow/tfjob_controller.go 0 3 0.0%
pkg/controller.v1/xgboost/xgboostjob_controller.go 0 3 0.0%
pkg/common/util/reconciler.go 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/common/util/reconciler.go 3 16.5%
Totals Coverage Status
Change from base Build 3390627896: 0.3%
Covered Lines: 2366
Relevant Lines: 5925

💛 - Coveralls

@djwhatle
Copy link

djwhatle commented Nov 3, 2022

This resolved the issue scheduling TFJobs with volcano for me!

Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
@google-oss-prow google-oss-prow bot added size/L and removed size/XS labels Nov 4, 2022
@ggaaooppeenngg
Copy link
Contributor Author

This pr fixes the previous wrong pr #1666 and uses generic functions for the podgroup callbacks. This pr also adds a test for the XXXFunc which only handles pod and service objects instead of other generic objects. @johnugeorge @D0m021ng @Crazybean-lwb

Signed-off-by: Peng Gao <peng.gao.dut@gmail.com>
@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggaaooppeenngg, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 53ae870 into kubeflow:master Nov 4, 2022
@johnugeorge
Copy link
Member

Dynamic watcher ref: #1688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

panic happened when add podgroup watch
4 participants