Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Golangci-lint #1685

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Upgrade Golangci-lint #1685

merged 5 commits into from
Nov 4, 2022

Conversation

johnugeorge
Copy link
Member

Upgrade Golangci-lint to the latest release 1.50.1

@coveralls
Copy link

coveralls commented Nov 3, 2022 •
edited

Pull Request Test Coverage Report for Build 3382696084

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 39.527%
Totals Coverage Status
Change from base Build 3380673253: -0.2%
Covered Lines: 2340
Relevant Lines: 5920
💛 - Coveralls

tenzen-y
tenzen-y reviewed Nov 3, 2022
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!

@tenzen-y
Copy link
Member

tenzen-y commented Nov 3, 2022

/lgtm
/hold for waiting for review by maintainers.

@google-oss-prow google-oss-prow bot added the lgtm label Nov 3, 2022
terrytangyuan
terrytangyuan approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

tenzen-y commented Nov 4, 2022

/hold cancel

@google-oss-prow google-oss-prow bot merged commit ba703a3 into kubeflow:master Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@gaocegege gaocegege Awaiting requested review from gaocegege

@jinchihe jinchihe Awaiting requested review from jinchihe

@zw0610 zw0610 Awaiting requested review from zw0610

Assignees

@terrytangyuan terrytangyuan

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@johnugeorge @coveralls @tenzen-y @terrytangyuan