[chore] Upgrade some actions version #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Pull Request Test Coverage Report for Build 3383757834
💛 - Coveralls |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm cancel |
|
@tenzen-y metadata-action also needs to be upgraded? |
Yes, we also need to upgrade docker/metadata-action version. I will push changes to this PR soon. |
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
|
@johnugeorge Pushed. |
tenzen-y
changed the title
|
/hold |
|
We need to upgrade other actions. Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, docker/setup-buildx-action, docker/login-action, docker/metadata-action, docker/build-push-action, docker/build-push-action, docker/login-action, docker/setup-buildx-action, actions/checkout |
Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
tenzen-y
changed the title
|
/hold cancel @johnugeorge I pushed all changes. PTAL |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: tenzen-y yuki.iwai.tz@gmail.com
What this PR does / why we need it:
To resolve the following warning, I upgraded the following actions:
actions/checkout-> v3docker/metadata-action-> v4docker/setup-buildx-action-> v2docker/login-action-> v2docker/build-push-action-> v3Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #
Checklist: