Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated Job Labels #1702

Merged
merged 11 commits into from
Dec 22, 2022
Merged

Removing deprecated Job Labels #1702

merged 11 commits into from
Dec 22, 2022

Conversation

johnugeorge
Copy link
Member

Deprecated Job labels are removed. Fully qualified labels will only be available.

Ref: kubeflow/common#200 kubeflow/common#149

@coveralls
Copy link

coveralls commented Dec 22, 2022

Pull Request Test Coverage Report for Build 3756888857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.2%) to 39.248%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 3 77.35%
pkg/controller.v1/paddlepaddle/paddlepaddle_controller.go 3 55.53%
pkg/controller.v1/pytorch/pytorchjob_controller.go 3 59.42%
pkg/controller.v1/tensorflow/tfjob_controller.go 3 70.7%
Totals Coverage Status
Change from base Build 3750765194: -0.2%
Covered Lines: 2661
Relevant Lines: 6780

💛 - Coveralls

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 69813fb into kubeflow:master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants