Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update the use of MultiWorkerMirroredStrategy in TF #1715

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

terrytangyuan
Copy link
Member

@terrytangyuan terrytangyuan commented Dec 31, 2022

The current implementation is experimental and deprecated.

_CollectiveAllReduceStrategyExperimental.__init__ (from tensorflow.python.distribute.collective_all_reduce_strategy) is deprecated and will be removed in a future version.
Instructions for updating:
use distribute.MultiWorkerMirroredStrategy instead

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Dec 31, 2022

Pull Request Test Coverage Report for Build 3810119636

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.03%) to 39.231%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 77.18%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 59.52%
Totals Coverage Status
Change from base Build 3808317272: 0.03%
Covered Lines: 2663
Relevant Lines: 6788

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 31, 2022
@google-oss-prow google-oss-prow bot merged commit 531c19d into master Dec 31, 2022
@terrytangyuan terrytangyuan deleted the terrytangyuan-patch-1 branch December 31, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants