Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indents on examples for tensorflow #1726

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I fixed indents on examples for tensorflow.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3936423213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 39.143%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.99%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 59.52%
Totals Coverage Status
Change from base Build 3894456879: 0.0%
Covered Lines: 2657
Relevant Lines: 6788

💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jan 17, 2023

Pull Request Test Coverage Report for Build 3936423213

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 39.143%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.99%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 59.52%
Totals Coverage Status
Change from base Build 3894456879: 0.0%
Covered Lines: 2657
Relevant Lines: 6788

💛 - Coveralls

@johnugeorge
Copy link
Member

/lgtm
/approve

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

@terrytangyuan @johnugeorge integration tests are flaky. Can you restart failed CI job?

@google-oss-prow google-oss-prow bot merged commit 6eaf3a3 into kubeflow:master Jan 17, 2023
@tenzen-y tenzen-y deleted the fix-example-indent branch January 17, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants