Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix scaledown error, upgrade PyTorch version to v1.13.1 in echo example #1733

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jan 20, 2023

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
I upgraded PyTorch version to v1.13.1 to fix the scaledown error in echo example.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1504

Checklist:

  • Docs included if any changes are user facing

…ample

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

coveralls commented Jan 20, 2023

Pull Request Test Coverage Report for Build 3970648635

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 39.423%

Totals Coverage Status
Change from base Build 3969930919: 0.2%
Covered Lines: 2676
Relevant Lines: 6788

💛 - Coveralls

@johnugeorge
Copy link
Member

@tenzen-y Curious. What was the change in 1.13.1 that fixed the error?

@tenzen-y
Copy link
Member Author

@tenzen-y Curious. What was the change in 1.13.1 that fixed the error?

@johnugeorge This is a bug reported in PyTorch community.

ref: pytorch/pytorch#67742

So, by upgrading the PyTorch version, we can fix that errors.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

@johnugeorge Can you restart failed Job?

@google-oss-prow google-oss-prow bot merged commit 6383a91 into kubeflow:master Jan 20, 2023
@tenzen-y tenzen-y deleted the upgrade-pytorch-version branch January 20, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytorch elastic scheduler error
3 participants