Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update join Slack link #1750

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Update join Slack link #1750

merged 1 commit into from
Feb 16, 2023

Conversation

Syulin7
Copy link
Contributor

@Syulin7 Syulin7 commented Feb 3, 2023

What this PR does / why we need it:
Update it to https://www.kubeflow.org/docs/about/community/#kubeflow-slack which will always have a working link. (rather than using the invited link directly).

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
fix: kubeflow/community#602
like kubeflow/community#604

Checklist:

  • Docs included if any changes are user facing

@Syulin7 Syulin7 changed the title update slack link Update join Slack link Feb 3, 2023
@Syulin7
Copy link
Contributor Author

Syulin7 commented Feb 3, 2023

@tenzen-y @johnugeorge PTAL, Thanks.

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks for the updates!

/lgtm

/assign @gaocegege @johnugeorge @terrytangyuan

@johnugeorge
Copy link
Member

Sorry for missing this

/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, Syulin7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

coveralls commented Feb 16, 2023

Pull Request Test Coverage Report for Build 4080282064

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 39.303%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 5 76.97%
pkg/controller.v1/pytorch/pytorchjob_controller.go 9 57.87%
Totals Coverage Status
Change from base Build 4066710325: 0.0%
Covered Lines: 2719
Relevant Lines: 6918

💛 - Coveralls

@google-oss-prow google-oss-prow bot merged commit 8d0bc09 into kubeflow:master Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Invitation to Kubeflow workspace in the Readme is no longer available
6 participants