Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python installation in CI #1759

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

tenzen-y
Copy link
Member

Signed-off-by: Yuki Iwai yuki.iwai.tz@gmail.com

What this PR does / why we need it:
This PR fixes the following error in CI:

[integration-test (v1.25.2, none, 3.8)](https://github.com/kubeflow/training-operator/actions/runs/4166979917/jobs/7211993949#step:3:9)
The `python-version` input is not set. The version of Python currently in `PATH` will be used.

https://github.com/kubeflow/training-operator/actions/runs/4166979917

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y tenzen-y changed the title Fix CI Fix Python installation in CI Feb 14, 2023
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@coveralls
Copy link

coveralls commented Feb 14, 2023

Pull Request Test Coverage Report for Build 4170321509

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 39.356%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 2 76.97%
Totals Coverage Status
Change from base Build 4147261027: -0.2%
Covered Lines: 2725
Relevant Lines: 6924

💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks @tenzen-y

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a1df7c2 into kubeflow:master Feb 14, 2023
@tenzen-y tenzen-y deleted the fix-ci branch February 14, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants