Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK version to 1.6.0 in release branch #1785

Merged
merged 10 commits into from
Mar 21, 2023
Merged

Update SDK version to 1.6.0 in release branch #1785

merged 10 commits into from
Mar 21, 2023

Conversation

johnugeorge
Copy link
Member

SDK is updated to 1.6.0

@johnugeorge johnugeorge changed the title Update SDK version to 1.6.0 Update SDK version to 1.6.0 in release branch Mar 21, 2023
@coveralls
Copy link

coveralls commented Mar 21, 2023

Pull Request Test Coverage Report for Build 4482378342

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.356%

Totals Coverage Status
Change from base Build 4482073091: 0.0%
Covered Lines: 2725
Relevant Lines: 6924

💛 - Coveralls

@johnugeorge
Copy link
Member Author

@tenzen-y Can you take a look at the error?
walk.go:74: found symbolic link in path: /home/runner/work/training-operator/training-operator/manifests/overlays/standalone/scheduler-plugins/manifests/install/charts/as-a-second-scheduler/crds resolves to /home/runner/work/training-operator/training-operator/manifests/overlays/standalone/scheduler-plugins/manifests/crds. Contents of linked file included and used

@tenzen-y
Copy link
Member

@tenzen-y Can you take a look at the error? walk.go:74: found symbolic link in path: /home/runner/work/training-operator/training-operator/manifests/overlays/standalone/scheduler-plugins/manifests/install/charts/as-a-second-scheduler/crds resolves to /home/runner/work/training-operator/training-operator/manifests/overlays/standalone/scheduler-plugins/manifests/crds. Contents of linked file included and used

Sure. Please give me some time.

@tenzen-y
Copy link
Member

tenzen-y commented Mar 21, 2023

@johnugeorge Can you cherry-pick this commit (d46247c) into this PR?

I have created a PR for the cherry-pick: #1786

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member

/hold

@tenzen-y
Copy link
Member

@johnugeorge #1786 was merged. So can you rebase?

@google-oss-prow google-oss-prow bot removed the lgtm label Mar 21, 2023
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm
/hold cancel

@google-oss-prow google-oss-prow bot added the lgtm label Mar 21, 2023
@google-oss-prow google-oss-prow bot merged commit 66aa635 into kubeflow:v1.6-branch Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants