Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Train api init container creation #1958

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Train api init container creation #1958

merged 11 commits into from
Dec 12, 2023

Conversation

deepanker13
Copy link
Contributor

@deepanker13 deepanker13 commented Dec 7, 2023 •
edited

What this PR does / why we need it:

  1. Adding a new folder for creating init container images with a docker file in it.
  2. Adding hugging face as the model provider.
  3. storage.py will start the download of models to the mount path.
  4. changes require python 3.11
    Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
    Partially Fixes Train/Fine-tune API Proposal for LLMs #1945
    Checklist:
  • Docs included if any changes are user facing

@deepanker13
Copy link
Contributor Author

@johnugeorge

@coveralls
Copy link

coveralls commented Dec 7, 2023 •
edited

Pull Request Test Coverage Report for Build 7181083550

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 42.872%
Totals Coverage Status
Change from base Build 7140843265: 0.0%
Covered Lines: 3753
Relevant Lines: 8754
💛 - Coveralls

@deepanker13 deepanker13 mentioned this pull request Dec 8, 2023
Merged
1 task
@johnugeorge
Copy link
Member

Please rebase

@deepanker13
Copy link
Contributor Author

Please rebase

done @johnugeorge

@deepanker13 deepanker13 mentioned this pull request Dec 11, 2023
Merged
1 task
@deepanker13
Copy link
Contributor Author

Hi @andreyvelich @kuizhiqing , can you please have a look at this PR.

@johnugeorge
Copy link
Member

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Dec 12, 2023
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepanker13, johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4de1761 into kubeflow:master Dec 12, 2023
33 checks passed
tenzen-y
tenzen-y reviewed Dec 27, 2023
View reviewed changes
sdk/python/kubeflow/storage_init_container/Dockerfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deepanker13 @johnugeorge Can we add a workflow to build this image?

@rimolive rimolive mentioned this pull request Jan 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnugeorge johnugeorge johnugeorge left review comments

@tenzen-y tenzen-y tenzen-y left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@johnugeorge johnugeorge

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deepanker13 @coveralls @johnugeorge @tenzen-y