Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 #2043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8578297700Details
💛 - Coveralls |
1 task
Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
jdcfd
force-pushed
the
bump-crd-ref-gen-version
branch
from
d9a1450
to
1f566c8
Compare
Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
jdcfd
force-pushed
the
bump-crd-ref-gen-version
branch
from
1f566c8
to
93320d0
Compare
|
Hi @tenzen-y , sorry for the delayed response. I added the new asciidoc file that was generated by running |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jdcfd, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
kubeflow#2043) * Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> * added generated api doc Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> --------- Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
johnugeorge
pushed a commit
to johnugeorge/training-operator
that referenced
this pull request
Apr 28, 2024
kubeflow#2043) * Fix: upgrade version of crd-ref-docs, which caused panic with go v1.22 Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> * added generated api doc Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com> --------- Signed-off-by: Juan Diego Colmenares Fernandez <cielocfd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade version of crd-ref-docs v0.0.8 -> v0.0.11. Default version causes panic with Go v1.22. This issue might prevent new developers from contributing to the project.
Which issue(s) this PR fixes:
Fixes #2025 .
Checklist: