Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement webhook validations for the PaddleJob #2057

Merged

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
I implemented webhook validations for the PaddleJob.
Additionally, I didn't add any additional validations. The traininig-operator has the same validations the same as before.

Although we potentially commonize podTemplate validations, I leave such commonize in the follow-ups.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #1993

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8643582806

Details

  • 38 of 61 (62.3%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 35.136%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/webhooks/paddlepaddle/paddlepaddle_webhook.go 38 61 62.3%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 8643045211: -0.06%
Covered Lines: 4346
Relevant Lines: 12369

💛 - Coveralls

@tenzen-y
Copy link
Member Author

/assign @andreyvelich @johnugeorge

@tenzen-y
Copy link
Member Author

/hold
for review.

@johnugeorge
Copy link
Member

/hold cancel
/lgtm

@google-oss-prow google-oss-prow bot merged commit b9d41b0 into kubeflow:master Apr 11, 2024
38 checks passed
@tenzen-y tenzen-y deleted the implement-paddle-webhook-validations branch April 11, 2024 12:51
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
johnugeorge pushed a commit to johnugeorge/training-operator that referenced this pull request Apr 28, 2024
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants